Re: MDAM techniques and Index Skip Scan patch

From: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Julien Rouhaud <rjuju123(at)gmail(dot)com>, Floris Van Nee <florisvannee(at)optiver(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: MDAM techniques and Index Skip Scan patch
Date: 2022-03-22 20:00:08
Message-ID: 20220322200008.yadxrrr6n3pbj4qp@erthalion.local
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Mon, Mar 21, 2022 at 06:34:09PM -0700, Andres Freund wrote:
>
> > I don't mind having all of the alternatives under the same CF item, only
> > one being tested seems to be only a small limitation of cfbot.
>
> IMO it's pretty clear that having "duelling" patches below one CF entry is a
> bad idea. I think they should be split, with inactive approaches marked as
> returned with feeback or whatnot.

On the other hand even for patches with dependencies (i.e. the patch A
depends on the patch B) different CF items cause a lot of confusion for
reviewers. I guess for various flavours of the same patch it would be
even worse. But I don't have a strong opinion here.

> Either way, currently this patch fails on cfbot due to a new GUC:
> http://api.cirrus-ci.com/v1/artifact/task/5134905372835840/log/src/test/recovery/tmp_check/regression.diffs
> http://cirrus-ci.com/task/5134905372835840

This seems to be easy to solve.

Attachment Content-Type Size
v41-0001-Unique-expressions.patch text/x-diff 16.1 KB
v41-0002-Index-skip-scan.patch text/x-diff 40.7 KB
v41-0003-amskip-implementation-for-Btree.patch text/x-diff 33.2 KB
v41-0004-Extend-amskip-implementation-for-Btree.patch text/x-diff 20.6 KB
v41-0005-Extend-index-skip-scan-with-ScanLooseKey.patch text/x-diff 5.4 KB
v41-0006-Index-skip-scan-for-IndexScan.patch text/x-diff 14.4 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2022-03-22 20:33:50 Re: MDAM techniques and Index Skip Scan patch
Previous Message Alvaro Herrera 2022-03-22 19:24:57 Re: Column Filtering in Logical Replication